-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix(dashboard): option value input #3618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dashboard): option value input #3618
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe code was updated to change the way unique IDs are generated for new option values in a component. Instead of using Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant OptionValueInputComponent
User->>OptionValueInputComponent: Triggers add value action
OptionValueInputComponent->>OptionValueInputComponent: Generate ID using Date.now().toString()
OptionValueInputComponent->>OptionValueInputComponent: Add new value with generated ID
OptionValueInputComponent->>User: Update UI with new value
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
npm error Exit handler never called! 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
All contributors have signed the CLA ✍️ ✅ |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/dashboard/src/app/routes/_authenticated/_products/components/option-value-input.tsx(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
`packages/dashboard/**/*`: Use React, Shadcn UI & tailwind, TanStack Query for d...
packages/dashboard/**/*: Use React, Shadcn UI & tailwind, TanStack Query for data fetching (useQuery or useMutation), and TanStack router for routing & navigation. Do not use Apollo Client.
📄 Source: CodeRabbit Inference Engine (.cursor/rules/dashboard.mdc)
List of files the instruction was applied to:
packages/dashboard/src/app/routes/_authenticated/_products/components/option-value-input.tsx
`packages/dashboard/src/app/**/*`: Follow consistent patterns for CRUD list/deta...
packages/dashboard/src/app/**/*: Follow consistent patterns for CRUD list/detail pages as exemplified by administrators.tsx and administrators_.$id.tsx. Use common components and hooks across all pages.
📄 Source: CodeRabbit Inference Engine (.cursor/rules/dashboard.mdc)
List of files the instruction was applied to:
packages/dashboard/src/app/routes/_authenticated/_products/components/option-value-input.tsx
packages/dashboard/src/app/routes/_authenticated/_products/components/option-value-input.tsx
Show resolved
Hide resolved
|
Thanks for the contribution. Once you sign the CLA (see comment above) we can get this merged 👍 |
|
I have read the CLA Document and I hereby sign the CLA |
61bed48
into
vendure-ecommerce:minor



Description
Fix for #3611
Breaking changes
Not really
Checklist
📌 Always:
👍 Most of the time:
Summary by CodeRabbit