Nightly #3720

danielhanchen · 2025-12-12T13:48:00Z

No description provided.

for more information, see https://pre-commit.ci

@danielhanchen

* Fix get_input_embeds call for VLMs * patch input_require_grads instead * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * cleanup old patch * cleanup old patch * cleanup * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Apply suggestion from @danielhanchen * use logger instead of prints * Move unsloth present set * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Daniel Han <danielhanchen@gmail.com>

for more information, see https://pre-commit.ci

gemini-code-assist · 2025-12-12T13:48:26Z

Summary of Changes

Hello @danielhanchen, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on maintenance, compatibility improvements, and internal refactoring. It updates a core dependency, introduces new patches to enhance compatibility with vision models and TRL's OpenEnv module, and streamlines the logging infrastructure. Additionally, it includes a version bump and a minor adjustment to the trainer's padding-free collator logic under specific conditions.

Highlights

Dependency Updates: The unsloth_zoo dependency has been updated to version 2025.12.4 in pyproject.toml, ensuring compatibility with the latest features and fixes.
New Compatibility Patches: Two new patches have been introduced: one to transformers.PreTrainedModel.enable_input_require_grads for better vision model compatibility, and another to trl.experimental.openenv to resolve NameError when vllm is not installed.
Improved Logging: The logging mechanism has been refactored to use unsloth_zoo.log.logger instead of direct print statements, providing more structured and controllable logging output across various patching functions.
Trainer Logic Enhancement: Padding-free collators are now explicitly disabled in the trainer when the UNSLOTH_RETURN_LOGITS environment variable is set, preventing potential conflicts.
Version Bump: The internal version of Unsloth has been incremented to 2025.12.5.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

chatgpt-codex-connector

💡 Codex Review

unsloth/unsloth/__init__.py

Lines 73 to 77 in b5b57b3

    
           # Check for unsloth_zoo 
        
           try: 
        
               unsloth_zoo_version = importlib_version("unsloth_zoo") 
        
               if Version(unsloth_zoo_version) < Version("2025.12.3"): 
        
                   print(

Raise runtime unsloth_zoo floor to match new dependency

The runtime version gate still allows unsloth_zoo 2025.12.3, but this commit both bumps the packaging requirement to unsloth_zoo>=2025.12.4 and starts importing new symbols such as unsloth_zoo.utils.Version (e.g., in trainer.py). In environments where an older 2025.12.3 install is already present or installed with --no-deps, the check here will pass even though the new imports will raise ImportError, preventing unsloth from loading. The minimum version enforced at import should be raised to the new floor.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…ightly

gemini-code-assist

Code Review

This pull request introduces several updates and fixes, including a version bump for unsloth_zoo, refactoring of initialization code, and new patches for transformers and trl compatibility. The logging has been improved by replacing print statements with a proper logger.

My review focuses on improving code style and robustness. I've pointed out a few places where bare except blocks are used, which can be risky. I've also suggested a minor cleanup of redundant parentheses.

Overall, the changes are positive and improve the library's stability and maintainability.

gemini-code-assist · 2025-12-12T13:55:17Z

unsloth/import_fixes.py

+    import inspect
+    from transformers import PreTrainedModel
+
+    # Check if the original function iterates over self.modules() instead of just returning the enable_input_require_grads


Using a bare except: is generally discouraged as it can catch unexpected exceptions like SystemExit or KeyboardInterrupt, making it harder to debug and interrupt the program. It's better to catch specific exceptions, or Exception at the very least.

Suggested change

# Check if the original function iterates over self.modules() instead of just returning the enable_input_require_grads

except Exception:

gemini-code-assist · 2025-12-12T13:55:17Z

unsloth/import_fixes.py

+    if importlib.util.find_spec("trl") is None:
+        return
+    trl_location = importlib.util.find_spec("trl").origin
+    trl_location = os.path.split(trl_location)[0]


There's a minor style issue here. According to PEP 8, there should be no spaces around the = sign for keyword arguments. It should be encoding="utf-8".

Suggested change

trl_location = os.path.split(trl_location)[0]

with open(openenv, "r+", encoding="utf-8") as f:

gemini-code-assist · 2025-12-12T13:55:17Z

unsloth/models/_utils.py

+
+    diffusers_logger.addFilter(HideLoggingMessage("are deprecated"))
+    del diffusers_logger
+except:


Using a bare except: is generally discouraged as it can catch unexpected exceptions like SystemExit or KeyboardInterrupt, making it harder to debug and interrupt the program. It's better to catch specific exceptions, or Exception at the very least.

Suggested change

except:

except Exception:

gemini-code-assist · 2025-12-12T13:55:18Z

unsloth/trainer.py

        # We also disable vision language models for padding free collators
        blocked = (
-            data_collator is not None
+            (data_collator is not None)


The extra parentheses around data_collator is not None are redundant since the entire boolean expression is already enclosed in parentheses. Removing them would make the code slightly cleaner.

Suggested change

(data_collator is not None)

data_collator is not None

danielhanchen and others added 28 commits December 9, 2025 01:02

Update _utils.py

e53e185

Merge branch 'main' into nightly

150eadf

Merge branch 'main' into nightly

25a6250

Merge branch 'main' into nightly

6b908cf

Merge branch 'main' into nightly

f754bd2

[pre-commit.ci] auto fixes from pre-commit.com hooks

30ade52

for more information, see https://pre-commit.ci

Merge branch 'main' into nightly

94bbcaa

Merge branch 'main' into nightly

30b78c5

Merge branch 'main' into nightly

f357fc5

Merge branch 'main' into nightly

a63a337

Update rope_embedding.py

2c22ce6

Merge branch 'main' into nightly

449430d

Fixes

b5f1a77

Update _utils.py

c94f595

Update import_fixes.py

01319d3

Update rl_replacements.py

696a540

fix_openenv_no_vllm

ac54d6e

Fix

9a98139

Update __init__.py

680f19f

Update __init__.py

fb763f3

Update __init__.py

f4f2a7f

Update import_fixes.py

e17b62f

Update import_fixes.py

f34eb0a

Update import_fixes.py

04ad21c

logger

32b52a0

Update __init__.py

0c9288f

[pre-commit.ci] auto fixes from pre-commit.com hooks

b5b57b3

for more information, see https://pre-commit.ci

chatgpt-codex-connector bot reviewed Dec 12, 2025

View reviewed changes

danielhanchen added 2 commits December 12, 2025 05:51

Update __init__.py

efb5801

Merge branch 'nightly' of https://github.com/unslothai/unsloth into n…

12ccc47

…ightly

danielhanchen merged commit 8490f6e into main Dec 12, 2025
3 of 4 checks passed

gemini-code-assist bot reviewed Dec 12, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Nightly #3720

Nightly #3720

danielhanchen commented Dec 12, 2025

Uh oh!

gemini-code-assist bot commented Dec 12, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Dec 12, 2025

Uh oh!

gemini-code-assist bot Dec 12, 2025

Uh oh!

gemini-code-assist bot Dec 12, 2025

Uh oh!

gemini-code-assist bot Dec 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	# Check for unsloth_zoo
	try:
	unsloth_zoo_version = importlib_version("unsloth_zoo")
	if Version(unsloth_zoo_version) < Version("2025.12.3"):
	print(

	# Check if the original function iterates over self.modules() instead of just returning the enable_input_require_grads
	except Exception:

	trl_location = os.path.split(trl_location)[0]
	with open(openenv, "r+", encoding="utf-8") as f:

Uh oh!

Nightly #3720

Nightly #3720

Conversation

danielhanchen commented Dec 12, 2025

Uh oh!

gemini-code-assist bot commented Dec 12, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants