Skip to content

Add gemma-3n chat template to chat_templates.py #3051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danielhanchen merged 2 commits into from
Jul 29, 2025
Merged

Add gemma-3n chat template to chat_templates.py #3051

danielhanchen merged 2 commits into from
Jul 29, 2025

Conversation

@Etherll
Copy link
Collaborator

@Etherll Etherll commented Jul 28, 2025 •
edited
Loading

I see in gemma-3n notebook we use

from unsloth.chat_templates import get_chat_template
tokenizer = get_chat_template(
    tokenizer,
    chat_template = "gemma-3",
)

but gemma-3n chat_template is kind of deferent for inferencing with images and has audio soft token

Datta0
Datta0 reviewed Jul 29, 2025
View reviewed changes
Copy link
Collaborator

@Datta0 Datta0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion, rest looks good

unsloth/chat_templates.py Outdated
Comment on lines 1258 to 1262
CHAT_TEMPLATES["gemma-3n"] = (gemma3n_template, gemma3n_template_eos_token, False, gemma3n_ollama,)
DEFAULT_SYSTEM_MESSAGE["gemma-3n"] = None # No system message in Gemma-3n

CHAT_TEMPLATES["gemma-3n"] = (gemma3n_template, gemma3n_template_eos_token, False, gemma3n_ollama,)
DEFAULT_SYSTEM_MESSAGE["gemma-3n"] = None # No system message in Gemma-3n
Copy link
Collaborator

@Datta0 Datta0 Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated lines?

Copy link
Collaborator Author

@Etherll Etherll Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh second one should be CHAT_TEMPLATES["gemma3n"] thanks for pointing this out

@danielhanchen danielhanchen merged commit 72579e5 into unslothai:main Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Datta0 Datta0 Datta0 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Etherll @Datta0 @danielhanchen