UI: Fix Copy button overlapping code in portrait mode #33420
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes storybookjs#23642 Increased paddingRight in syntaxhighlighter.tsx to 85px. This prevents the code text from running under the absolute positioned "Copy" button when viewing in mobile/portrait modes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23642
What I did
I increased the
paddingRightin theSyntaxHighlightercomponent to85px.This prevents the code text from running under the absolute positioned "Copy" button when viewing in mobile/portrait modes.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing