[#70149] Configure Herb for HTML-aware ERb linting #21495
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix malformed HTML (e.g. unmatched closing tags) as well as other issues
identified as "parse errors" when running:
herb analyze .
https://community.openproject.org/work_packages/70148
Fixes `InvalidNestingError` found when running:
herb analyze .
Also creates an initial config via:
npx herb-lint --init
Ensures compliance with `erb-require-whitespace-inside-tags` rule. See: https://herb-tools.dev/linter/rules/erb-require-whitespace-inside-tags
myabc
changed the title
myabc
changed the base branch from
release/17.0
to
bug/70148-fix-erb-html-errors-using-herb
npx herb-lint --fix
This causes rendering issues in widgets that make use of tag helpers since it overrides `ActionView::Helpers::TagHelper#tag` albeit with a different signature. This option does not appear to be used currently. This partially reverts commit 585bb74
myabc
force-pushed
the
code-maintenance/70149-herb
branch
from
50dafad to
5f14900
Compare
myabc
commented
Dec 21, 2025
| <colgroup> | ||
| <% columns.each do |column| %> | ||
| <col <%= "opHighlightCol" unless column.attribute == :hierarchy %>> | ||
| <col <% if column.attribute == :hierarchy %>data-highlight="false"<% end %>> |
myabc
force-pushed
the
bug/70148-fix-erb-html-errors-using-herb
branch
from
9ec2f6c to
8378e6d
Compare
Base automatically changed from
bug/70148-fix-erb-html-errors-using-herb
to
release/17.0
December 22, 2025 14:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/70149
What are you trying to accomplish?
Screenshots
There should be no visible changes.
What approach did you choose and why?
What this PR doesn't do
The following Herb compilation errors will not be fixed:
Merge checklist