Skip to content

Conversation

@Light2Dark
Copy link
Contributor

📝 Summary

Screen.Recording.2025-12-09.at.9.11.22.AM.mov

🔍 Description of Changes

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

@vercel
Copy link

vercel bot commented Dec 9, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
marimo-docs Ready Ready Preview Comment Dec 9, 2025 10:50am

@Light2Dark Light2Dark marked this pull request as ready for review December 9, 2025 11:27
@Light2Dark Light2Dark requested a review from manzt as a code owner December 9, 2025 11:27
@mscolnick mscolnick merged commit d1e804e into main Dec 9, 2025
35 of 77 checks passed
@mscolnick mscolnick deleted the sham/add-not-in-filter branch December 9, 2025 17:37
@yan-hic
Copy link

yan-hic commented Dec 11, 2025

Cool ! Question (not tested yet): say style was applied on a cell e.g. hyperlink, what's the value that will filter or be copied: the visible value, the row value for the column or the hyperlink ?
Expected behavior: the second one, otherwise df won't effectively filter. For copy, you may consider the first as user would want to copy what it is displayed.

Will log another featReq btw, to expose the result of the filtered df - currently, it only has the selected ones (and source).
Use case: summary stat cards should show the sum, count,... of filtered df to make it dynamic (like in Excel, subtotal of visible cells).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants