Skip to content

Conversation

@Light2Dark
Copy link
Contributor

@Light2Dark Light2Dark commented Dec 8, 2025

📝 Summary

Fixes #7408
Previously the notebook banner would stretch the entire notebook (when the panel is open), because the notebook panel is shifted. This PR removes that sticky css, only placing it on the left.

Screen.Recording.2025-12-09.at.12.28.17.AM.mov

I did find another way to make it sticky (using container queries), but I'm not sure if there are side effects of the below change.

<Panel id="app-chrome-body" className="[container-type:inline-size]">
        width === "columns" && "sticky left-12 w-full max-w-[80cqw]",

🔍 Description of Changes

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

@Light2Dark Light2Dark requested a review from manzt as a code owner December 8, 2025 16:33
@Light2Dark Light2Dark added the bug Something isn't working label Dec 8, 2025
@vercel
Copy link

vercel bot commented Dec 8, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
marimo-docs Ready Ready Preview Comment Dec 8, 2025 4:33pm

@mscolnick
Copy link
Contributor

the container query is nice, but maybe just better to be simpler. its a nice fix too

@Light2Dark Light2Dark merged commit 89e15ea into main Dec 9, 2025
26 checks passed
@Light2Dark Light2Dark deleted the sham/fix-notebook-banner-width-column branch December 9, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nit: Reconnected banner cannot be interacted with without scrolling to rightmost column in column view

3 participants