-
Notifications
You must be signed in to change notification settings - Fork 19.1k
fix: i18n: stop running translation #28571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: NeatGuyCoding <15627489+NeatGuyCoding@users.noreply.github.com>
Summary of ChangesHello @NeatGuyCoding, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on refining the internationalization efforts by correcting specific translation strings that previously conveyed a literal meaning of 'stop run' rather than the intended 'stop execution' or 'stop operation'. By updating these phrases across numerous languages, the change ensures that the user interface is more intuitive and professional for a global audience, improving overall usability and comprehension. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes the translation for 'stop run' across multiple languages. The original translations were often too literal, implying physical running, but have now been updated to the intended meaning of 'stop execution'. The changes are accurate and improve the user interface's clarity for international users.
While reviewing these translation files, I noticed a related and significant translation issue for the executions key in several languages (e.g., Korean, German, Farsi, Thai, Turkish, Vietnamese). The term has been translated to mean 'capital punishment' instead of 'program executions'. While this is outside the scope of the current changes, I highly recommend creating a follow-up PR to correct this to avoid user confusion and potential offense.
Overall, the changes in this PR are excellent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes incorrect translations across 21 language files where "stop run" was mistranslated to refer to physical running/jogging instead of stopping program execution. The translations now correctly convey the concept of stopping a workflow or process execution.
- Updates translation strings for
stopRunin share.ts files across multiple locales - Updates translation string for
stopin the workflow.ts trigger section for Traditional Chinese - Ensures consistency with related terms like "execution" and "executions" in each language
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| web/i18n/zh-Hant/workflow.ts | Fixed Traditional Chinese trigger stop button from "stop running (jogging)" to "stop execution" |
| web/i18n/zh-Hant/share.ts | Fixed Traditional Chinese stopRun from "stop running (jogging)" to "stop execution" |
| web/i18n/zh-Hans/share.ts | Fixed Simplified Chinese stopRun from "stop running (jogging)" to "stop execution" |
| web/i18n/vi-VN/share.ts | Fixed Vietnamese stopRun from "stop" to "stop execution" for clarity |
| web/i18n/uk-UA/share.ts | Fixed Ukrainian stopRun from "stop, don't run" to "stop execution" |
| web/i18n/tr-TR/share.ts | Fixed Turkish stopRun from "stop run" to "stop execution" |
| web/i18n/th-TH/share.ts | Fixed Thai stopRun from "stop running" to "stop working/execution" |
| web/i18n/sl-SI/share.ts | Fixed Slovenian stopRun from "stop running" to "stop execution" |
| web/i18n/ru-RU/share.ts | Fixed Russian stopRun from "stop while running away" to "stop execution" |
| web/i18n/ro-RO/share.ts | Fixed Romanian stopRun from "stop running" to "stop execution" |
| web/i18n/pt-BR/share.ts | Fixed Brazilian Portuguese stopRun from "stop running" to "stop execution" |
| web/i18n/pl-PL/share.ts | Fixed Polish stopRun from "stop running" to "stop execution" |
| web/i18n/ko-KR/share.ts | Fixed Korean stopRun from "stop running" to "stop execution" |
| web/i18n/ja-JP/share.ts | Fixed Japanese stopRun from "stop running" to "stop execution" |
| web/i18n/it-IT/share.ts | Fixed Italian stopRun from "stop the race" to "stop execution" |
| web/i18n/id-ID/share.ts | Fixed Indonesian stopRun from "stop running" to "stop execution" |
| web/i18n/hi-IN/share.ts | Fixed Hindi stopRun from "stop or stop running" to "stop execution" |
| web/i18n/fr-FR/share.ts | Fixed French stopRun from "stop running" to "stop execution" |
| web/i18n/fa-IR/share.ts | Fixed Persian stopRun from "stop, run" to "stop execution" |
| web/i18n/es-ES/share.ts | Fixed Spanish stopRun from "stop race" to "stop execution" |
| web/i18n/de-DE/share.ts | Fixed German stopRun from "stop run/race" to "stop execution" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thanks for the PR, however please link an issue in the description. |
Signed-off-by: NeatGuyCoding <15627489+NeatGuyCoding@users.noreply.github.com>
Important
Fixes #<issue number>.Summary
Screenshots
Checklist
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods