fix: logical error in Weaviate distance calculation

[DhruvGorasiya]

Important

1. Make sure you have read our contribution guidelines
2. Ensure there is an associated issue and you have been assigned to it
3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Screenshots

Before	After
...	...

Checklist

• This change requires a documentation update, included: Dify Document
• I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
• I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
• I've updated the documentation accordingly.
• I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

[gemini-code-assist]

Summary of Changes

Hello @DhruvGorasiya, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a logical error in Weaviate distance calculation and updates the Weaviate client and server versions to 4.17.0 and 1.27.0 respectively. It includes necessary dependency pinning, temporary Docker Compose adjustments for the client update, and a detailed migration guide to assist users in upgrading their Weaviate instances. The changes aim to improve accuracy, leverage newer Weaviate features like gRPC for faster operations, and provide clear instructions for a smooth transition.

Highlights

• Weaviate Distance Calculation Fix: Corrected a logical error in weaviate_vector.py to explicitly handle None values for obj.metadata.distance, ensuring 1.0 is used as a fallback when the distance is not available.
• Weaviate Client Version Pin: Updated and pinned the weaviate-client Python package to version 4.17.0 across pyproject.toml and uv.lock to ensure compatibility with the updated Weaviate server.
• Docker Compose Adjustments: Introduced temporary entrypoint overrides in Docker Compose files (docker-compose-template.yaml, docker-compose.yaml) to ensure weaviate-client==4.17.0 is installed at runtime, and removed an empty profile entry from the Weaviate service definition.
• Weaviate Migration Guide: Added a comprehensive README.md document detailing the migration process from Weaviate v1.19 to v1.27, including breaking changes, improvements, step-by-step instructions for Docker and source installations, troubleshooting, and rollback procedures.

Ignored Files

• Ignored by pattern: .github/workflows/** (1)
  • .github/workflows/expose_service_ports.sh

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly addresses a logical error in the Weaviate distance calculation, ensuring that a distance of 0.0 is handled properly. The dependency on weaviate-client is also pinned to a specific version, which improves build reproducibility. The addition of a detailed Weaviate migration guide is a valuable contribution for users. My review includes suggestions to improve code conciseness in the distance calculation, enhance maintainability in the Docker Compose files by reducing duplication, and fix minor formatting issues in the new documentation to improve clarity.