Skip to content

(small) fix conditional for input_ids and input_embeds in marian #40045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArthurZucker merged 2 commits into from
Aug 21, 2025
Merged

(small) fix conditional for input_ids and input_embeds in marian #40045

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84dc7d7
(small) fix conditional for input_ids and input_embeds in marian
cyntqliu Aug 8, 2025
3478772
address comment
cyntqliu Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/transformers/models/marian/modeling_marian.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -979,16 +979,14 @@ def forward(

# retrieve input_ids and inputs_embeds
if (input_ids is None) ^ (inputs_embeds is not None):
raise ValueError("You cannot specify both decoder_input_ids and decoder_inputs_embeds at the same time")
raise ValueError("You must specify exactly one of input_ids or inputs_embeds")
elif input_ids is not None:
input = input_ids
input_shape = input.shape
input_ids = input_ids.view(-1, input_shape[-1])
elif inputs_embeds is not None:
input_shape = inputs_embeds.size()[:-1]
input = inputs_embeds[:, :, -1]
else:
raise ValueError("You have to specify either decoder_input_ids or decoder_inputs_embeds")

if inputs_embeds is None:
inputs_embeds = self.embed_tokens(input)
Expand Down