Tie weights recursively on all submodels #39996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
reviewed
Aug 8, 2025
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
LGTM otherwise, but this piece of code if very very... tricky haha
| # Leading to issues on subsequent calls by different tests or subsequent calls. | ||
| self._dynamic_tied_weights_keys = tied_weights | ||
|
|
||
| def tie_weights(self): |
Collaborator
There was a problem hiding this comment.
bit scared about the recursivity as we call that function 10 times....
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: blip, seamless_m4t, seamless_m4t_v2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #39900. Current code calls custom
_tie_weightsrecursively on allmodules, but does not recursively ties the embeddings or the encoder/decoder parts