Skip to content

Conversation

@KeyKy
Copy link
Contributor

@KeyKy KeyKy commented Aug 6, 2025

@amyeroberts , @qubvel

Issue: shortest_edge and longest_edge in preprocess_config.json are being ignored during GLM-4V image preprocessing. Please investigate and fix.

Copy link
Contributor

@qubvel qubvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @KeyKy, thanks for the PR, I updated your implementation to respect the default size as well, please see the suggestion below

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025

[For maintainers] Suggested jobs to run (before merge)

run-slow: glm4v

@qubvel
Copy link
Contributor

qubvel commented Aug 6, 2025

run-slow: glm4v

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025

This comment contains run-slow, running the specified jobs:

models: ['models/glm4v']
quantizations: [] ...

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@qubvel qubvel merged commit cb2e0df into huggingface:main Aug 6, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants