Skip to content

Conversation

@jakeret
Copy link

@jakeret jakeret commented Jul 30, 2025

What does this PR do?

This PR fixes an issue in the transformers serve functionality where the server could not handle chat messages with nested content (e.g., when the content field in a message was a list instead of a string or dictionary). The unhandled TypeError caused the server to crash instead of processing the request or returning a meaningful error message.

Fixes #39791

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed.

@gante
Copy link
Contributor

gante commented Jul 31, 2025

@jakeret thank you for opening the PR (and sorry for not noticing it before opening #39829 !)

I think #39829 cover more cases (a list with multiple items in content), but let me know if you think it misses some functionality :)

@jakeret
Copy link
Author

jakeret commented Jul 31, 2025

@gante no worries. In my tests with gradio I didn't encounter the case where the list contained more than one item. Thats why I only fetched the first item.
Could it be that #39829 now misses one of the original cases where content=message["content"]["text"] ?

@gante
Copy link
Contributor

gante commented Aug 4, 2025

@jakeret that case should be covered (and has tests 👍 )

@jakeret
Copy link
Author

jakeret commented Aug 5, 2025

@gante I think it's sill missing the case where message["content"] contains a dict.

I've pushed a new commit to this PR, that handles and tests. all cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

transformers serve Fails to Handle Messages with Nested Content

2 participants