HIVE-29333: Ignore NoClassDefFoundError when registering Iceberg UDFs in FunctionRegistry #6214
Conversation
… in FunctionRegistry
|
|
@thomasrebele, could you please attach the stacktrace |
|
Unfortunately I've forgot to save the stacktrace, and I've also forgot which test caused the problem. If I encounter it again, I'll add the stacktrace. It happened at least twice in the last three months, so it's quite likely to happen again. |
| system.registerGenericUDF("iceberg_zorder", | ||
| (Class<? extends GenericUDF>) Class.forName("org.apache.iceberg.mr.hive.udf.GenericUDFIcebergZorder")); | ||
| } catch (ClassNotFoundException e) { | ||
| } catch (ClassNotFoundException | NoClassDefFoundError e) { |
There was a problem hiding this comment.
In general, we should not try to catch instances of Error in application code. Moreover, the Javadoc of NoClassDefFoundError writes the following:
* The searched-for class definition existed when the currently
* executing class was compiled, but the definition can no longer be
* found.If we get this exception then it seems more like an IDE config issue rather than something that we need to fix here.
|
As I understand here we just swallow the issue if there is the NoClassDefFoundError happened. but if this happens i think it is serious. Or do you have a context why we should silently "handle"? |
|
The context would be debugging in the IDE. There were two cases where I arrived at this exception. Once I got it fixed by adding the required jars to the "project structure" in Intellij. The second time I had to run a I've seen a few debug options in HiveConf. How about adding a |
5 participants
What changes were proposed in this pull request?
Ignore NoClassDefFoundError in addition to the already ignored ClassNotFoundException.
Why are the changes needed?
A NoClassDefFoundError is sometimes thrown when debugging tests in Intellij IDEA.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manually while debugging a qfile test with Intellij IDEA.