Include k8s novolume (version v0.8.0) #4063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds the v0.8.0 version of the runner-container-hooks to the Docker image as a fallback mechanism. The change downloads and extracts the new hook version to a separate k8s-novolume directory while preserving the existing v0.7.0 hooks in the k8s directory.
- Downloads runner-container-hooks v0.8.0 to a separate directory for fallback support
- Maintains existing v0.7.0 hooks alongside the new version
- Supports the new "novolume" mode being introduced in ARC
Comment on lines
+24
to
+26
| RUN curl -f -L -o runner-container-hooks.zip https://github.com/actions/runner-container-hooks/releases/download/v0.8.0/actions-runner-hooks-k8s-0.8.0.zip \ | ||
| && unzip ./runner-container-hooks.zip -d ./k8s-novolume \ | ||
| && rm runner-container-hooks.zip |
There was a problem hiding this comment.
The code duplicates the download logic from lines 20-22. Consider combining both downloads into a single RUN instruction with different variables for version and directory, or create a helper script to reduce duplication.
rentziass
approved these changes
Oct 2, 2025
TingluoHuang
force-pushed
the
nikola-jokic/include-k8s-novolume
branch
from
4db76e6 to
35dde84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once the hook v0.8.0 is released, pull it down into a separate directory.
The change in the v0.8.0 is fairly risky, so we ideally want to apply the fallback mechanism to the current version of the hook v0.7.0.
ARC PR: actions/actions-runner-controller#4250 introduces a new mode, including this path to the hook.