Skip to content

Conversation

@mxstbr
Copy link
Contributor

@mxstbr mxstbr commented Jun 27, 2018

Not sure when you'd ever want your ServiceWorker to not update ever? That seems like the way less common case than updating on change.

Not sure when you'd ever want your ServiceWorker to not update ever? That seems like the way less common case than updating on change.
@GGAlanSmithee
Copy link
Collaborator

GGAlanSmithee commented Jul 25, 2018

@mxstbr

Thanks for this, makes sense too me. Corresponding docs needs to be updated too.

BTW - is true (= 1 hour) the most reasonable default, or should we have a slightly longer default, say 10 hours or something like that?

@NekR does this update make sense to you?

@mxstbr
Copy link
Contributor Author

mxstbr commented Jul 27, 2018

BTW - is true (= 1 hour) the most reasonable default, or should we have a slightly longer default, say 10 hours or something like that?

I think it should be shorter, if anything?

@GGAlanSmithee
Copy link
Collaborator

@mxstbr yeah, was thinking it might be a large change going from never auto-updating to once an hour as a default, but I agree it makes more sense to have it be shorter.

@NekR
Copy link
Owner

NekR commented May 9, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants