can't add new conversations while reviewing PR

[viceice]

I can add comments to existing conversations but cannot start new conversations

app version: 1.237.1

same issue on latest beta

[kangarruu]

Hey @viceice thanks for the heads up! Is this happening on iOS or Android? You're able to respond to existing comments but not add new comments? Are you referring to the PR screen where the PR summary is? Or directly in the files changed view?

[viceice]

it's happening on Android PR files view

[kangarruu]

Thanks for clarifying, do you mind describing what happens? Are you able to start the comment flow but the comment does not post when you submit? Or you do not able to launch the comment composer at all?

[viceice]

yes, you can start it and hit the send arrow. then you see the waiting circle and nothing happens. conversation is never added

[viceice]

it seems to work again in v1.238.1 (894) 🎉

[viceice]

it's not working again right now 😭

[ricardoV94]

Same here, can't really review PRs anymore

[MITHRADEVIK3009]

Hi @viceice , @ricardoV94
When the spinner hangs, does it happen on both Wi-Fi and Cellular? If you kill the app and restart, is your comment text still there or is it lost?

[viceice]

now tested on cellular and have same issue.

comment is gone when stopping and reopen the app

[MITHRADEVIK3009]

Thanks for testing that, @viceice. That’s a huge help. Since the comment is lost on restart, it confirms there's no local caching happening. One more quick check: when it's hanging on that 'waiting circle,' are you able to hit the 'Back' button to cancel, or is the whole screen frozen? Also, does this happen on every PR you try, or only specific ones (e.g., very large PRs with many files)?

[viceice]

it's happening on every PR now. and I can go back without any issue. it canceled the post. if I then try again without closing app, then my message is still there.

[viceice]

it only happens when trying to add a new conversatio. all other commenting works. 🤔

[Rob--W]

To me it happens on wifi and cellular, started happening relatively recently, maybe past two weeks or so. The spinner keeps spinning forever. I can go back, and when I click on the line my previously typed comment is still there. When I force close the app and navigate back to the PR, the comment is still there. I just cannot save it.

[MITHRADEVIK3009]

Hi @kangarruu
Is there a specific telemetry event tied to the 'send' action that we can track to see if the request is reaching the gateway or timing out at the client-side state management?

[MITHRADEVIK3009]

Thanks for the extra context @viceice and @Rob--W.

@Rob--W: That’s interesting that yours persists after a force close but @viceice’s doesn't. Are you on a Beta version of the app, and which Android OS version are you using?

@viceice: When you say it only happens on 'new conversations,' does it fail even if you are just adding a single comment, or only when you try to 'Start a Review' with multiple comments?

[viceice]

it happens on a single comment

[Rob--W]

@Rob--W: That’s interesting that yours persists after a force close but @viceice’s doesn't. Are you on a Beta version of the app, and which Android OS version are you using?

Latest non-beta (1.239.0), Android 16.

I tried tapping on a line, a comment box pops up. I can add suggestions and a comment, but not submit it.

To check the persistence, I swiped away the app, then I opened the app, navigated to a PR, and tapped on a line where I wrote something before but it failed to submit. The box showed what I wrote before, but when I press the submit button, it keeps spinning.

[Coding-Hen]

I have also experienced this as well. Tried cold restarting the phone as well still no luck. As mentioned above comments are still visible without submissions, adding comments to existing conversations still work.

Using android 16 as well.

[kangarruu]

Hi all, so sorry that you're facing this issue. I'm afraid I cannot reproduce the problem, but we will keep investigating. Please keep us updated!

[Rob--W]

I can only reproduce this problem on some repositories, e.g.

mdn/content#42410
mdn/browser-compat-data#28683

I can add comments to other PRs in the following orgs: mozilla, w3c, but not in mdn for some reason.

If you'd like me to take extra steps to assist in debugging, let me know.

[viceice]

I've seen it on https://github.com/renovatebot/renovate